The PR improves the maxuploadtarget functional tests by checking the reported flags (getnettotals RPC target_reached and serve_historical_blocks ), checking the proper log messages are present when disconnection happens (in order to make it easier to check whether or not there’s test coverage for those disconnection reasons), plus adds an additional disconnection check by issuing MEMPOOL messages once the upload limit has been reached, but the peer has been whitelisted for block download only.
The change is pretty straightforward and an easy improvement of the test. I just left a couple of partially unrelated comments that could be squashed into the PR given we are improving the test anyway.